fix(clerk-js): patch active signup resource in Future API by jacekradko · Pull Request #8558 · clerk/javascript

jacekradko · 2026-05-15T12:33:18Z

Future signUp.update() and signUp.sso() were PATCHing the collection URL (/client/sign_ups) instead of the active sign-up's URL (/client/sign_ups/<id>) when continuing an existing sign-up. The call sites passed path: this.#resource.pathRoot explicitly, which bypassed BaseResource.path() and dropped the id.

Removing the explicit path lets the base class build the right URL, matching how password() already handled the same branch. Adds regression tests for update(), existing-id sso(), and the ticket() + sso() flow.

Fixes #8551.

changeset-bot · 2026-05-15T12:33:24Z

🦋 Changeset detected

Latest commit: 66d73bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@clerk/clerk-js	Patch
@clerk/chrome-extension	Patch
@clerk/expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-05-15T12:33:24Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 15, 2026 0:42am

coderabbitai · 2026-05-15T12:44:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a8f7df53-d5c4-4ab4-b57e-dc4a8a35d6fb

📥 Commits

Reviewing files that changed from the base of the PR and between f2477b9 and 66d73bd.

📒 Files selected for processing (3)

.changeset/signup-future-resource-path.md
packages/clerk-js/src/core/resources/SignUp.ts
packages/clerk-js/src/core/resources/__tests__/SignUp.test.ts

📝 Walkthrough

Walkthrough

This PR fixes a resource-path URL-construction issue in SignUpFuture.update() and SignUpFuture.sso() methods. Two lines in the implementation remove the explicit path parameter from __internal_basePatch calls, enabling the methods to use the active sign-up resource's path. Tests validate that both methods now issue PATCH requests to the resource URL (/client/sign_ups/{id}) instead of the collection URL. A changeset documents the patch release for @clerk/clerk-js.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title clearly and concisely summarizes the main fix: patching the active signup resource in the Future API, which is the primary objective of the changeset.
Description check	✅ Passed	The PR description is directly related to the changeset, explaining the bug root cause, the solution, and the test coverage added.
Linked Issues check	✅ Passed	The PR successfully addresses issue `#8551` by removing explicit path parameter so the base class builds the correct resource URL with the ID included, fixing signUp.sso() and signUp.update() to PATCH the resource URL instead of collection URL.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to the linked issue `#8551`: updating the changeset documentation, fixing SignUpFuture.update() and SignUpFuture.sso() methods, and adding regression tests for the affected flows.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-15T12:47:57Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8558

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8558

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8558

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8558

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8558

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8558

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8558

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8558

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8558

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8558

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8558

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8558

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8558

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8558

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8558

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8558

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8558

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8558

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8558

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8558

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8558

commit: 66d73bd

fix(clerk-js): patch active signup resource in future api

35371de

github-actions Bot added the clerk-js label May 15, 2026

vercel Bot deployed to Preview May 15, 2026 12:33 View deployment

jacekradko marked this pull request as ready for review May 15, 2026 12:41

Merge branch 'main' into jacek/fix-signup-future-sso-ticket

66d73bd

vercel Bot deployed to Preview May 15, 2026 12:42 View deployment

dstaley approved these changes May 15, 2026

View reviewed changes

jacekradko merged commit 6b27d54 into main May 15, 2026
43 checks passed

jacekradko deleted the jacek/fix-signup-future-sso-ticket branch May 15, 2026 18:35

clerk-cookie mentioned this pull request May 15, 2026

ci(repo): Version packages #8555

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(clerk-js): patch active signup resource in Future API#8558

fix(clerk-js): patch active signup resource in Future API#8558
jacekradko merged 2 commits into
mainfrom
jacek/fix-signup-future-sso-ticket

jacekradko commented May 15, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented May 15, 2026 •

edited

Loading

Uh oh!

vercel Bot commented May 15, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 15, 2026

Walkthrough

Estimated code review effort

Uh oh!

pkg-pr-new Bot commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jacekradko commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 15, 2026

Walkthrough

Estimated code review effort

Uh oh!

pkg-pr-new Bot commented May 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jacekradko commented May 15, 2026 •

edited

Loading

changeset-bot Bot commented May 15, 2026 •

edited

Loading

vercel Bot commented May 15, 2026 •

edited

Loading